fix(accounts): survive an auth plane older than the SDK's principal schema - #29
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing principals crashed against a real endpoint:
Those three fields are declared by
@constructive-io/sdk's generated types — the published package is generated from a newer schema than the auth plane being talked to, so the types promise fields the server has never heard of. Nothing on this side can type-check that away; the drift is between the package and the deployment.So the query asks optimistically and degrades:
missingFieldmatches onlyCannot query field, deliberately narrow: aSTEP_UP_REQUIREDor a permission error must not be retried as if it were drift (and the retry re-throws properly, so a second failure isn't swallowed).Losing
isActive/useAdminOwnercosts detail, not correctness — their absence already means inherited, which is exactly whatreadPrincipaldefaults them to.createOrgPrincipalnow omitsuseAdminOwnerfrom the input rather than sending it asnull, for the same reason: don't ask an older server about a field it doesn't have.Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation